Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of columns on both sides of a lookup argument #249

Open
OlivierBBB opened this issue Aug 20, 2024 · 2 comments
Open

Number of columns on both sides of a lookup argument #249

OlivierBBB opened this issue Aug 20, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@OlivierBBB
Copy link
Collaborator

OlivierBBB commented Aug 20, 2024

It seems (though I'm not sure entirely which tests are being run on the CI) that corset didn't complain about a missing column in a lookup, see Consensys/linea-constraints@3094e96

  • target provided with 6 columns
  • source provided with only 5

If the compiler doesn't pick this up (and assuming that the CI actually attempts to produce the zkevm.bin object this is a bug.

@OlivierBBB OlivierBBB added the bug Something isn't working label Aug 20, 2024
@DavePearce
Copy link
Collaborator

This this does report an error:

(defcolumns X Y Z)
(deflookup test (Y) ((+ X 1) Z))

as does the opposite:

(defcolumns X Y Z)
(deflookup test (Y Z) ((+ X 1)))

@DavePearce
Copy link
Collaborator

@OlivierBBB where is the commit where you actually fixed this? The one above is not on any branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants