Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tx v3 Support in StarkNet Snap to allow user to pay fees in STRK or ETH #274

Closed
khanti42 opened this issue Jul 2, 2024 · 0 comments

Comments

@khanti42
Copy link
Collaborator

khanti42 commented Jul 2, 2024

Issue: Add tx v3 Support in StarkNet Snap

Description

This issue aims to add comprehensive support for tx v3 (transaction version 3) across various functionalities in the StarkNet Snap. The primary goal is to ensure that tx v3 is fully integrated and operational within the starkNet_sendTransaction, estimateFee, estimateFeeBulk, and starkNet_createAccount functions, enhancing the overall capabilities of the StarkNet Snap.

The following pull requests (PRs) contribute to this objective:

PRs Overview

  1. feat: support txv3 in estimateFee and estimateFeeBulk [SNAP] #262

    • Description: This PR introduces support for tx v3 in the estimateFee and estimateFeeBulk functions. These updates ensure that fee estimation processes are compatible with the new transaction version, providing accurate and reliable fee calculations.
    • Key Changes:
      • Updated estimateFee to handle tx v3.
      • Updated estimateFeeBulk to handle tx v3.
  2. feat: support txv3 in estimateFee (UI) #263

    • Description: This PR focuses on updating the user interface (UI) to support tx v3 in the estimateFee function. It ensures that the UI components correctly reflect the changes and provide a seamless user experience when estimating fees with tx v3.
    • Key Changes:
      • UI adjustments to accommodate tx v3 in estimateFee.
  3. feat: [UI] support tx v3 in wallet-ui #271

    • Description: This PR adds support for tx v3 within the starkNet_sendTransaction function. It includes necessary updates to ensure that transactions sent via the Snap adhere to the tx v3 specifications, enhancing transaction handling and compatibility.
    • Key Changes:
      • Modified starkNet_sendTransaction to support tx v3.
      • UI updates for transaction sending process with tx v3.
  4. feat: [SNAP] supporting tx v3 in starkNet_createAccount #273

    • Description: This PR introduces support for tx v3 in the starkNet_createAccount function. It ensures that account creation processes within the Snap are compatible with tx v3, facilitating seamless account management.
    • Key Changes:
      • Updated starkNet_createAccount to handle tx v3.

Implementation Steps

  1. Merge PR feat: support txv3 in estimateFee and estimateFeeBulk [SNAP] #262:
  2. Merge PR feat: support txv3 in estimateFee (UI) #263:
  3. Merge PR feat: [UI] support tx v3 in wallet-ui #271:
  4. Merge PR feat: [SNAP] supporting tx v3 in starkNet_createAccount #273:

Conclusion

By merging these PRs, we will achieve early support for tx v3 in the StarkNet Snap allowing users to pay fees in both ETH and STRK, enhancing its functionality and ensuring compatibility with the latest transaction standards.

@khanti42 khanti42 closed this as completed Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant