Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_crosslink_committees_at_slot() #438

Closed
benjaminion opened this issue Mar 8, 2019 · 1 comment
Closed

Update get_crosslink_committees_at_slot() #438

benjaminion opened this issue Mar 8, 2019 · 1 comment
Assignees
Labels
enhancement 🕵️‍♀️ New feature or request

Comments

@benjaminion
Copy link
Contributor

Description

As an implemeter, I want get_crosslink_committees_at_slot() to match the v0.4 spec so that Artemis performs as other clients expect.

Acceptance Criteria

  • get_crosslink_committees_at_slot() matches the 0.4 specification

Additional Information

Just a minor re-ordering of the controlling if/else statement, I think (branches 1 & 2 need to be reordered), but the function would benefit from a thorough check against the spec.

See ethereum/consensus-specs#672

@benjaminion benjaminion added the enhancement 🕵️‍♀️ New feature or request label Mar 8, 2019
@benjaminion benjaminion added this to the Beacon Chain v0.4.0 Spec milestone Mar 8, 2019
@benjaminion benjaminion self-assigned this Mar 8, 2019
@benjaminion benjaminion added the in progress 🚧 This issue or pull request is in progress label Mar 8, 2019
@benjaminion benjaminion removed the in progress 🚧 This issue or pull request is in progress label Mar 10, 2019
@benjaminion
Copy link
Contributor Author

Closed by #440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🕵️‍♀️ New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant