Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define new types #6378

Closed
3 tasks
Tracked by #5681
tbenr opened this issue Nov 4, 2022 · 0 comments · Fixed by #6421
Closed
3 tasks
Tracked by #5681

Define new types #6378

tbenr opened this issue Nov 4, 2022 · 0 comments · Fixed by #6421
Assignees
Labels
Epic Deneb Issues required to implement Deneb upgrade

Comments

@tbenr
Copy link
Contributor

tbenr commented Nov 4, 2022

There are several new types defined in the spc. When these types are just alias of a generic type we use the generic one. But if these types are more complex or requires specific validation we have to create a specific class.

from polynomial commitments types we need to define:

  • KZGCommitment we need an ssz version of it like SszPublicKey (will be in BeaconBlockBody schema to build a list of them via SszListSchema.create(KZGCommitment, ...))
  • KZGProof we need an ssz version of it like SszPublicKey (will be part of BlobsSidecar schema)
  • Blob we need an ssz version defined via SszByteVectorSchema.create() (will be part of BlobsSidecar schema as SszListSchema.create(Blob, ..))
@tbenr tbenr added the Epic Deneb Issues required to implement Deneb upgrade label Nov 4, 2022
@zilm13 zilm13 self-assigned this Nov 8, 2022
@zilm13 zilm13 mentioned this issue Nov 10, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Deneb Issues required to implement Deneb upgrade
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants