Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Peer Exchange in PRUNE message #7860

Closed
diegomrsantos opened this issue Jan 5, 2024 · 3 comments · Fixed by #7894
Closed

Disable Peer Exchange in PRUNE message #7860

diegomrsantos opened this issue Jan 5, 2024 · 3 comments · Fixed by #7894
Assignees

Comments

@diegomrsantos
Copy link

Description

As described here ethereum/consensus-specs#3500, Peer Exchange isn't relevant to the Ethereum Network and PRUNE messages sent by Teku can have up to 9 KB and 210 peer IDs due to Peer Exchange.

The options to limit the number of peers sent and accepted in PRUNE messages have been fixed and improved in this PR libp2p/jvm-libp2p#336.

We suggest 2 phases for the implementation:

  1. A new jvm-libp2p version containing the mentioned PR is released. Teku is updated to use this version and set maxPeersSentInPruneMsg to zero. For compatibility reasons, maxPeersAcceptedInPruneMsg is set to a high value, potentially to the max Integer value.
  2. After some time has passed and all Teku nodes are expected to have been updated, maxPeersAcceptedInPruneMsg is also set zero.

Steps to Reproduce (Bug)

Inspect PRUNE messages sent by Teku over time.

Expected behavior:
Phases:

  1. Teku doesn't send peer IDs in PRUNE messages, but accept it from other peers.
  2. Teku doesn't send peer IDs in PRUNE messages and doesn't accept it from other peers.

Actual behavior:
Teku sends peer IDs in PRUNE messages and accept it from other peers.

Frequency:
Often

Versions (Add all that apply)

  • Software version: Not sure, but probably the latest and previous ones.
  • Java version: [java -version]
  • OS Name & Version: [cat /etc/*release]
  • Docker Version: [docker version]
  • Cloud VM, type, size: [Amazon Web Services I3-large]
@StefanBratanov
Copy link
Contributor

Thank you @diegomrsantos for raising this.:) We will look into releasing a new version of the libp2p and will take it from there.

@StefanBratanov
Copy link
Contributor

@diegomrsantos just to confirm both phases have been implemented

@diegomrsantos
Copy link
Author

@StefanBratanov thank you for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants