Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

funcSig feature fails when having methods with structs as arguments #155

Open
0xdcota opened this issue Jul 23, 2024 · 0 comments
Open

funcSig feature fails when having methods with structs as arguments #155

0xdcota opened this issue Jul 23, 2024 · 0 comments

Comments

@0xdcota
Copy link

0xdcota commented Jul 23, 2024

With a simple method as show below:

function enableBorrowingOnReserve(address asset, bool stableBorrowRateEnabled) external onlyPoolAdmin

The funcSig feature returns a new file with:

| Function Name | Sighash    | Function Signature | 
| ------------- | ---------- | ------------------ | 
| enableBorrowingOnReserve | eede87c1 | enableBorrowingOnReserve(address,bool) |

The above is great 👍

Now, the issue is

However, with a complex argument function such as:

function updateAToken(UpdateATokenInput calldata input) external onlyPoolAdmin

The funcSig returns nothing.. ❌

| Function Name | Sighash    | Function Signature | 
| ------------- | ---------- | ------------------ | 

I suppose the challenge is in interpreting: "what is UpdateATokenInput".

The methods above are in the Aave code base if you want to give it a try: https://github.com/aave/protocol-v2/blob/master/contracts/protocol/lendingpool/LendingPoolConfigurator.sol

@0xdcota 0xdcota changed the title funcSigs feature fails when having methods with structs as arguments funcSig feature fails when having methods with structs as arguments Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant