Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 404 NotFound when get document by hash fails #50

Open
marcinwadon opened this issue Oct 20, 2020 · 0 comments
Open

Return 404 NotFound when get document by hash fails #50

marcinwadon opened this issue Oct 20, 2020 · 0 comments
Assignees
@mwadon

Comments

@marcinwadon
Copy link
Member

marcinwadon commented Oct 20, 2020 •
edited
Loading

Ideally, we should map elasticsearch errors to our custom ones.
i.e. below we can see that elasticsearch returned 404 status code. It would be great not to return exact reason to end user.

image.png

Consider such a mapping:

Elasticsearch -> Our own

404 Not Found -> 404 Not Found
anything else -> 500 Internal Server Error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwadon mwadon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mwadon @marcinwadon