-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker image for LTS packages #403
Conversation
2bab155
to
822ad7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repo was heavily cleaned up and polished in the last two years, unused / non-maintained things have be removed and all remaining containers where harmonised to have them generated for all linux platforms from a single sourced Dockerfile.
We publish build containers here so that customers/users can reproduce package builds or to build packages/channel on top of defaults or for tooling alignments (with e.g. the community). Everything in the build container is open source.
Though I don't see any OSS anaconda-time-machine / anaconda-time-machine-feedstock anywhere.
So a new container added as part of a POC with a package from a private channel is not something that fits here. Please instead pin the version of the existing container in the abs.yaml of feedstocks and run conda install -c jcmorin-ana-org --quiet --yes anaconda-time-machine
in the build flows when something is build that needs that (based on a abs.yaml property)... If the POC succeeds then please make the package + feedstock OSS, add it to either defaults or shared maintained tools channel and then this container can happen.
After talking with @dbast, we agreed to go ahead with this PR. Anaconda is currently working on an experiment and due to time constraints (and technical details relating to our build infrastructure), we had to take some shortcuts and couldn't get everything in the open in time. Hence why the package and feedstock are private. Like Daniel said, if the PoC is a success, we will revisit this to open source the package and feedstock and everything else necessary. |
Co-authored-by: Daniel Bast <[email protected]>
Co-authored-by: Daniel Bast <[email protected]>
lets retag/release the default build image to have an uptodate version there... and then just add the lts specific things without additional updates of conda/conda-build.... the images would otherwise contain completely different versions... the update of the normal build image is anyways overdue, to have all the system and conda packages updated (with supposedly lots of bugs fixed) |
Given that Prefect doesn't pin the docker image by default, I'm thinking we don't tie the base docker image into this trial-work. I agree we should update conda there, but it need not be tied to this work and can be done explicitly. |
Add docker image for LTS packages from base image with
conda-time-machine
plugin installed