From 7c331efb67da7534fb381fd662d40d4016ad8f20 Mon Sep 17 00:00:00 2001 From: Jules Fouchy Date: Tue, 3 Sep 2024 12:01:44 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=9A=A8=20Fix=20build?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/release_installer.yml | 2 +- CMakeLists.txt | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release_installer.yml b/.github/workflows/release_installer.yml index 1864975..d14020a 100644 --- a/.github/workflows/release_installer.yml +++ b/.github/workflows/release_installer.yml @@ -6,7 +6,7 @@ on: - "*" env: - cmake_configure_args: -D WARNINGS_AS_ERRORS_FOR_COOLLAB_LAUNCHER=ON + cmake_configure_args: "" # -D WARNINGS_AS_ERRORS_FOR_COOLLAB_LAUNCHER=ON # TODO(Launcher) Check warnings cmakelists_folder: "." cmake_target: Coollab-Launcher diff --git a/CMakeLists.txt b/CMakeLists.txt index 21fc927..a77629c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -24,9 +24,9 @@ set(WARNINGS_AS_ERRORS_FOR_COOLLAB_LAUNCHER OFF CACHE BOOL "ON iff you want to t if(WARNINGS_AS_ERRORS_FOR_COOLLAB_LAUNCHER) if(MSVC) - target_compile_options(Coollab-Launcher-Properties PRIVATE /WX) + target_compile_options(Coollab-Launcher-Properties INTERFACE /WX) else() - target_compile_options(Coollab-Launcher-Properties PRIVATE -Werror) + target_compile_options(Coollab-Launcher-Properties INTERFACE -Werror) endif() endif()