Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid MSVC compiler warnings in Envelope #412

Closed
wants to merge 1 commit into from
Closed

Avoid MSVC compiler warnings in Envelope #412

wants to merge 1 commit into from

Conversation

rwols
Copy link
Contributor

@rwols rwols commented Jul 28, 2021 •
edited
Loading

Fixes #399

@rwols rwols mentioned this pull request Aug 3, 2021
Open
@SebDieBln
Copy link
Contributor

I just ran into the same warnings. Is there any progress with this PR?

@EmielBruijntjes
Copy link
Member

This pull request is not correct, as it does not solve the actual problem. The casting to 32 bit should not be necessary, as bigger payloads are valid in the AMQP protocol.

@EmielBruijntjes EmielBruijntjes deleted the avoid-compiler-warning-msvc-envelope branch April 25, 2022 09:21
@SebDieBln
Copy link
Contributor

This pull request is not correct, as it does not solve the actual problem. The casting to 32 bit should not be necessary, as bigger payloads are valid in the AMQP protocol.

I agree. I just looked at Message::setBodySize() and it contains an explicit check for such messages. So I guess the actual problem is in InBuffer::nextData() which takes a uint32_t as its size parameter instead of a size_t.

@SebDieBln SebDieBln mentioned this pull request Apr 25, 2022
Merged
@SebDieBln
Copy link
Contributor

@EmielBruijntjes Thanks for fixing the warnings in 328d9d1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

warnings in amqp-cpp that are treated as errors in our build
3 participants
@rwols @SebDieBln @EmielBruijntjes