Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subfolder support #85

Closed
JupiterThreads opened this issue Oct 22, 2021 · 4 comments
Closed

Subfolder support #85

JupiterThreads opened this issue Oct 22, 2021 · 4 comments

Comments

@JupiterThreads
Copy link

JupiterThreads commented Oct 22, 2021

So I've setup my django tenant app with subfolders, but I've had to introduce a workaround when I call the provision_tenant function. I've created a pre_save signal for my tenant class to remove the domain name, which is appended to the tenant slug on line 31 in the provision_tenant function. ​

Is there a better way of dealing with this issue and/or are you planning to accommodate for this requirement in a future release? Thanks!

@Dresdn
Copy link
Collaborator

Dresdn commented Oct 22, 2021

This shouldn't be too difficult to accommodate. I see the sub-folder feature is still in beta, but more than happy to either take a look at a PR, or take a stab at in the future.

As an FYI to where I'm personally at, the next big thing is to do one more small release, and then pull out all the django-tenant-schemas references as it seems to have died. With that, implementing new features/enhancements like this should be a lot simpler.

@JupiterThreads
Copy link
Author

Cool. I might be able to give it a go. I'm also intending to see if I can get django guardians to work with this app.

@tomturner
Copy link
Contributor

I know of no known bug with the subfolder feature. I have been using it for a while so I will be removing the fact it beta soon.

@JupiterThreads
Copy link
Author

pr submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants