mock_env() returns a contract address that cannot be validated

[webmaster128]

(https://github.com/CosmWasm/cosmwasm/blob/v2.0.3/packages/std/src/testing/mock.rs#L282). I.e. the address of the contract itself cannot be canonicalized.

---

I wonder if we should add a mock_env method to MockApi or use a free function with an api argument

[webmaster128]

With #2217 being merged now (mock_env changed to use default bech32 address instead of deprecated), @chipshort do you think we should continue this advanced approach as well? It can either be

• a free function that takes an API argument
• MockApi::mock_env
• a free function that takes the final Addr

Alternatively we can leave it up to the project to come up with their Env constructor.

[chipshort]

I think we could keep it in the backlog for a 3.0, where we can then make breaking changes to the existing functions, but I would not do it now. It feels quite awkward to have multiple versions of the mocking function doing almost the same thing, but not quite. And the naming is not very obvious either.
So, better to stay with the 80/20 solution for now and whoever needs custom prefixes can implement it themselves.
Then, in 3.0 we can switch over to the full solution.

[webmaster128]

Good call, I like! Added to milestone

[webmaster128]

Closing in favour of #2218. I consider this task 80% done in #2217