Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Entry points refactoring #397

Open
kulikthebird opened this issue Jul 18, 2024 · 0 comments
Open

chore: Entry points refactoring #397

kulikthebird opened this issue Jul 18, 2024 · 0 comments

Comments

@kulikthebird
Copy link
Contributor

We should consider refactoring of the entry_points macro, since it wasn't aligned with the latest features and design changes implemented in Sylvia. Potentially there's a way to simplify the code for generating entry points.

Also currently Sylvia implicitely requires that #[entry_points] macro be used before the #[contract]. If there is a way to make the attributes order redundant it would be really beneficial for users, as it would prevent some problems with lack of generated entry points in contracts. For sylvia v1.1 and older there's no warning/error message if #[entry_points] is placed in "wrong" order which may result in a contract binary without exposed entry point methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant