Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnyOfAddresses list Append/Remove #1491

Closed
JohnnyWyles opened this issue Jul 6, 2023 · 1 comment · Fixed by #1493
Closed

AnyOfAddresses list Append/Remove #1491

JohnnyWyles opened this issue Jul 6, 2023 · 1 comment · Fixed by #1493
Milestone

Comments

@JohnnyWyles
Copy link

This issue is to request that the parameter list is able to be added to or removed from by a governance proposal that submits a single address to change the status of.

AnyOfAddresses is a parameter list in the wasm module that allows a chain to have permissioned upload with exceptions for certain addresses building on the platform.

The way this is being modified on permissioned chains right now is by resubmitting the entire list with each parameter change proposal.

This relies on:

  1. Teams applying to be aware of this requirement and submit the correct addresses
  2. Proposals to modify this not to overlap or to assume that previous proposals will pass based on quorum at the time of submission.

This isn't hugely sustainable as more and more teams get access and we have run into #2 a few times already on Osmosis as teams coincidentally want to deploy at the same time.

osmosisd q wasm params
code_upload_access:
  address: ""
  addresses:
  - osmo1cd4nn8yzdrrsfqsmmvaafq8r03xn38qgqt8fzh
  - osmo1wl59k23zngj34l7d42y9yltask7rjlnxgccawc7ltrknp6n52fps94qsjd
  - osmo19vxp8vq8qm368dr026qxh8v82satwaf79y235lfv6wmgpwxx8dtskedaku
  - osmo1e0x2hnhhwyek7eq3kcxu2x6pt77wdnwz0lutz9fespdr9utq963qr0y5p5
  - osmo14n3a65fnqz9jve85l23al6m3pjugf0atvrfqh5
  - osmo15wna5dwylkuzvljsudyn6zfsd4zl0rkg5ge888mzk4vtnjpp0z5q4e9w58
  - osmo1r02tlyyaqs6tmrfa4jf37t7ewuxr57qp8ghzly
  - osmo1ae2z8svz9nvklt94mvrskr7kdwy0qrlrsehe6f
  - osmo1lqyn9ncwkcqj8e0pnugu72tyyfehe2tre98c5qfzjg4d3vdw7n5q5a0x37
  permission: AnyOfAddresses
instantiate_default_permission: Everybody
@alpe alpe added this to the v0.41.0 milestone Jul 7, 2023
@alpe
Copy link
Contributor

alpe commented Jul 7, 2023

This feature makes a lot of sense. Thanks for bringing this up!
I would suggest that we support adding/removing multiple addresses in a single message. Although there can be multiple messages in a v1 gov proposal, our command supports only 1.

Adding a duplicate address or removing a non existing address should be silently ignored and not fail the proposal. This are edge cases but there can be multiple in-flight proposals that eventually become persistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants