Instantiate contract process ordering

[yun-yeo]

Problem State

As you can see in terra-money/classic-core#399

If you store the instantiated contract after dispatching all messages, it will block the messages to use instantiated contract.

wasmd/x/wasm/internal/keeper/keeper.go

Lines 242 to 250 in ff37dc6

	err = k.dispatchMessages(ctx, contractAddress, res.Messages)
	if err != nil {
	return nil, err
	}
	// persist instance
	createdAt := types.NewAbsoluteTxPosition(ctx)
	instance := types.NewContractInfo(codeID, creator, admin, label, createdAt)
	store.Set(types.GetContractAddressKey(contractAddress), k.cdc.MustMarshalBinaryBare(instance))

Proposed solution

So recommend to store the instantiated contract data and dispatch response messages later.

[ethanfrey]

Good point. So the messages sent out can refer back to the newly instantiated contract. Will add to next release