-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add SetAttribute/DeleteAttribute KMIP operations #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manuthor
force-pushed
the
feat/add_set_attribute_kmip_operation
branch
2 times, most recently
from
September 18, 2024 09:24
2db038b
to
3c9f5ad
Compare
Manuthor
force-pushed
the
feat/add_set_attribute_kmip_operation
branch
3 times, most recently
from
September 23, 2024 07:32
6fa8cb1
to
af4b0c8
Compare
ccorsin
reviewed
Sep 24, 2024
Manuthor
force-pushed
the
feat/add_set_attribute_kmip_operation
branch
from
September 25, 2024 05:29
7c9b27e
to
3673ba3
Compare
ccorsin
reviewed
Sep 27, 2024
ccorsin
reviewed
Oct 4, 2024
ccorsin
approved these changes
Oct 4, 2024
Manuthor
force-pushed
the
feat/add_set_attribute_kmip_operation
branch
from
October 4, 2024 09:12
a15e383
to
d244258
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107
Implement the KMIP operations
SetAttribute
andDeleteAttribute
:server
:ckms
:SetAttributes
andDeleteAttributes
(multiple attributes being possible)get_attributes
:AttributeTag
by the KMIP tag struct to simplify/make more generic and make easier the get-attributes evolutionckms get-attributes --link-type
kmip
crate:clap-compliant
enums ObjectType, KeyFormatType, CryptographicAlgorithm, LinkType and Tagckms
args