Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SetAttribute/DeleteAttribute KMIP operations #303

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

Manuthor
Copy link
Contributor

@Manuthor Manuthor commented Sep 10, 2024

Closes #107

Implement the KMIP operations SetAttribute and DeleteAttribute:

  • on server:
    • these 2 operations are unitary (1 single attribute is set/deleted)
    • not all attributes can be set (there are a lot but main attributes can be (algo, links especially)
  • on ckms:
    • add 2 actions:
      • SetAttributes and DeleteAttributes (multiple attributes being possible)
    • test on every possible values of attributes
    • in get_attributes:
      • replace the struct AttributeTag by the KMIP tag struct to simplify/make more generic and make easier the get-attributes evolution
      • all links can be retrieved and also filtered if needed with the new action-parameter ckms get-attributes --link-type
  • on kmip crate:
    • make clap-compliant enums ObjectType, KeyFormatType, CryptographicAlgorithm, LinkType and Tag
    • then can be used directly in ckms args

@Manuthor Manuthor force-pushed the feat/add_set_attribute_kmip_operation branch 2 times, most recently from 2db038b to 3c9f5ad Compare September 18, 2024 09:24
@Manuthor Manuthor marked this pull request as ready for review September 18, 2024 09:25
@Manuthor Manuthor force-pushed the feat/add_set_attribute_kmip_operation branch 3 times, most recently from 6fa8cb1 to af4b0c8 Compare September 23, 2024 07:32
crate/cli/src/actions/console.rs Outdated Show resolved Hide resolved
crate/cli/src/actions/shared/delete_attributes.rs Outdated Show resolved Hide resolved
crate/cli/src/actions/shared/delete_attributes.rs Outdated Show resolved Hide resolved
crate/cli/src/actions/shared/delete_attributes.rs Outdated Show resolved Hide resolved
crate/server/src/core/operations/export_utils.rs Outdated Show resolved Hide resolved
crate/server/src/core/operations/export_utils.rs Outdated Show resolved Hide resolved
crate/server/src/core/operations/get_attributes.rs Outdated Show resolved Hide resolved
@Manuthor Manuthor force-pushed the feat/add_set_attribute_kmip_operation branch from 7c9b27e to 3673ba3 Compare September 25, 2024 05:29
crate/server/src/tests/test_set_attribute.rs Outdated Show resolved Hide resolved
crate/test_server/src/test_server.rs Show resolved Hide resolved
crate/kmip/src/kmip/kmip_operations.rs Outdated Show resolved Hide resolved
crate/cli/src/actions/shared/delete_attributes.rs Outdated Show resolved Hide resolved
@Manuthor Manuthor force-pushed the feat/add_set_attribute_kmip_operation branch from a15e383 to d244258 Compare October 4, 2024 09:12
@Manuthor Manuthor merged commit d15c114 into develop Oct 4, 2024
39 checks passed
@Manuthor Manuthor deleted the feat/add_set_attribute_kmip_operation branch October 4, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for SetAttributes KMIP operation
2 participants