Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt a code style convention #7

Open
EiffL opened this issue Mar 5, 2021 · 1 comment
Open

Adopt a code style convention #7

EiffL opened this issue Mar 5, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@EiffL
Copy link
Member

EiffL commented Mar 5, 2021

Since we are basing the code on TensorFlow, I suggest we follow the Google/TensorFlow code styling for python.

Here are some links to the documentation for this:

Essentially, the idea is that we are following pep8, but we only use 2 space tabs instead of 4.

I'll add a github action to run yapf on the code to make sure it is correctly formatted, will also add a pre-commit hook so that yapf can be run automatically before each commit.

@EiffL EiffL changed the title dopt Adopt a code style convention Mar 5, 2021
@EiffL EiffL self-assigned this Mar 5, 2021
@EiffL EiffL added the enhancement New feature or request label Mar 5, 2021
@EiffL
Copy link
Member Author

EiffL commented Jun 16, 2021

Still interested in feedback from @andrevitorelli and @sfarrens for this :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant