Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'L' key to scroll down on links screen scrolls twice, then repeats from starting point #74

Open
stoicism2323 opened this issue Apr 24, 2016 · 3 comments

Comments

@stoicism2323
Copy link
Contributor

So in a subreddit link screen I can hit L to load up to link number 52 (second page of links), then when I hit L again, link number 53 will be the same as link #1, and it will repeat from there. Continuing to hit L will continue to load these two pages, first and second page, over and over again.

@stoicism2323
Copy link
Contributor Author

I tried adding the contents of what happens when you hit the 'u' key to refresh the screen, but it only semi-works. Is there a better way to full-refresh the link screen?

@stoicism2323
Copy link
Contributor Author

Quick update about the 'L' key issue, I have what I think is a fix for this bug checked into my branch. In the vparseTokens function in libreddit/token.c, after a full block of JSON was parsed, the function would step out but end up stepping past an important key label ('after', which lets u know how to get to the next page of reddit links). I have fixed this by decrementing the currentToken after a successful performIdentAction has taken place.

Please let me know if it looks okay and I'll send out a pull request. Thanks!

@Cotix
Copy link
Owner

Cotix commented Jul 23, 2016

looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants