Squeel query returns outdated result

[dariusf]

Achievement condition validations cause a bug in squeel 1.2.3 where the ActiveRecord object returned is not up to date. The workaround implemented in #425 should be reverted when this is fixed.

def achievement_conditions(id)
  Course::Condition::Achievement.
    joins { condition.conditional(Course::Achievement) }.
    where{condition.conditional.id == id}
end

# Here achievement 2 has achievement 1 as a condition

achievement_conditions(2).first
=> #<Course::Condition::Achievement id: 1, achievement_id: 1>

achievement_conditions(2).first.achievement
=> #<Course::Achievement id: 2, course_id: 1, title: "two", description: "", weight: 10, published: false, creator_id: 1, updater_id: 1, created_at: "2015-07-23 03:35:19", updated_at: "2015-07-23 03:35:19">

achievement_conditions(2).first.achievement_id
=> 1

achievement_conditions(2).first.achievement.id
=> 2

c = achievement_conditions(2).first
=> #<Course::Condition::Achievement id: 1, achievement_id: 1>

c.achievement
=> #<Course::Achievement id: 2, course_id: 1, title: "two", description: "", weight: 10, published: false, creator_id: 1, updater_id: 1, created_at: "2015-07-23 03:35:19", updated_at: "2015-07-23 03:35:19">

# Result is correct after reload

c.reload
=> #<Course::Achievement id: 1, course_id: 1, title: "one", description: "", weight: 10, published: false, creator_id: 1, updater_id: 1, created_at: "2015-07-23 03:35:11", updated_at: "2015-07-23 03:35:11">

[lowjoel]

Maybe you can create a minimal repro and create in the Squeel issue tracker instead.

[lowjoel]

@allenwq has this been fixed?

[allenwq]

We have a TODO in our codebase already, and it's 1 year long so I cleaned this up.

[lowjoel]

I'd keep it open because it has not been fixed in Squeel. This would affect other parts soon enough.

[allenwq]

Sure.

[kxmbrian]

Closing this because squeel is no longer used after #2283.

[kxmbrian]

Some files related to #425 not yet cleaned up, e.g.:

• app/models/course/condition/achievement.rb
• app/models/course/condition/assessment.rb
• spec/models/course/condition/assessment_spec.rb
• spec/models/course/condition/achievement_spec.rb