Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually Awarded Achievement creates unwanted behavior when awarded towards Phantom Student #7435

Open
bivanalhar opened this issue Jul 15, 2024 · 0 comments

Comments

@bivanalhar
Copy link
Contributor

bivanalhar commented Jul 15, 2024

In awarding manual achievement for students, from the FE side the instructors can choose to award those achievement to Phantom Students. If the phantom student get awarded, they will get the notification upon signing-in to Coursemology and navigating to that mentioned course, however several unwanted behavior (possibly bug) occurs, as follows:

  • Other than that, when instructor wants to edit the awardees' list, those phantom students will have the red banner, possibly due to the difference in the backend data and how it's being interpreted in the frontend
  • In the list of awardees, also those phantom students are not being enlisted
Screenshot 2024-07-15 at 5 14 47 PM

In this picture, we didn't de-select those phantom students; they are automatically being de-selected by the system even though later on we can revert this selection. But this behavior is weird and it should be idempotent (the fact also is that if we refresh the page and then visit this page again, those phantom students will be marked as achieving those awards)

Suggested Fix

  • We also give the Phantom Students the right to get those manually awarded achievement, as well as how they can get the automatically awarded achievement
  • In addition, in the Achievement page (/courses/{courseId}/achievements/{achievementId}), there should be a toggle for including or excluding Phantom Students in the view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant