Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestUtils.getTypeByExtension() and WebM format #263

Open
djipco opened this issue Sep 12, 2019 · 2 comments
Open

RequestUtils.getTypeByExtension() and WebM format #263

djipco opened this issue Sep 12, 2019 · 2 comments

Comments

@djipco
Copy link

djipco commented Sep 12, 2019

In the RequestUtils.getTypeByExtension() method, the "webm" extension is there twice (line 110 and line 114). Is this intended?

I don't see how it could be detected as anything but createjs.Types.SOUND and I'm not sure this is necessarily the best default value for the WebM format.

I understand that we should specify the type explicitely but I stumbled upon that, while debugging a related issue, and figured I should report it.

@lannymcnie
Copy link
Member

It is probably just a mistake. If memory serves, there was a specific edge-case that that type handled. I am not sure it's still required.

Cheers,

@djipco
Copy link
Author

djipco commented Sep 12, 2019

I submitted PR #264 to fix this little mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants