Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Guide Link in CSV Is Path'd Incorrectly #584

Open
acornett21 opened this issue Sep 23, 2024 · 1 comment · May be fixed by #585
Open

Install Guide Link in CSV Is Path'd Incorrectly #584

acornett21 opened this issue Sep 23, 2024 · 1 comment · May be fixed by #585

Comments

@acornett21
Copy link

Problem

The install guides link in the CSV, points to this repo as a relative path, instead of a remote path. When the CSV is rendered in a cluster, this makes it seem that the guide is hosted at a route in the cluster, which it is not, and errors when a user clicks on it.

Solution

Point the link to an absolute (http) path either in this repo or on a CrowdStrike website.

Link to Code

https://github.com/CrowdStrike/falcon-operator/blob/main/bundle/manifests/falcon-operator.clusterserviceversion.yaml#L823

evanstoner added a commit to evanstoner/falcon-operator that referenced this issue Sep 23, 2024
evanstoner added a commit to evanstoner/falcon-operator that referenced this issue Sep 23, 2024
@evanstoner evanstoner linked a pull request Sep 23, 2024 that will close this issue
@evanstoner
Copy link
Contributor

Thanks @acornett21 ! I think I fixed that once in the generated manifest but not in the base, so it got overwritten. This should fix it for good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants