Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THANK YOU! #51

Open
goodwanghan opened this issue Jul 28, 2022 · 5 comments
Open

THANK YOU! #51

goodwanghan opened this issue Jul 28, 2022 · 5 comments

Comments

@goodwanghan
Copy link

Hi,

I want to thank you for creating this wonderful project. We recently created and open sourced https://github.com/fugue-project/fugue-jupyter which is heavily inspired by your work. Although we are not able to directly leverage this project because Fugue SQL has more syntax than standard SQL, we learned a lot from this project.

For now, we only enabled highlights, in the future we will also enable auto formatting and probably auto completion. You have all of them, that is amazing!

Han

@cccs-jc
Copy link
Collaborator

cccs-jc commented Aug 10, 2022

Hey @goodwanghan happy to hear this is of interest. I notice you are copying code for your needs.

It might be better if you used the the jupyterlab-sql-editor as a component in your project. Maybe with a bit of refactoring it would be reusable for your usecase.

I'm on vacation at the moment but would very much appreciate discussing this further with you.

@surjansr
Copy link

surjansr commented Sep 7, 2022

@cccs-jc @cccs-nik @cccs-mmrouet- huge thanks for creating this project. I am trying this out for my use case and able to use it when I install it from the running notebook but pre-configuration is not working. Is there any mailing-list or group to discuss any issues faced while using it before creating a git issue ?

@cccs-jc
Copy link
Collaborator

cccs-jc commented Sep 10, 2022

@surjansr we don't yet have a discussion board yet. So feel free to discuss here in the meantime.

Are you planning to use the extension as part of another project or use it as is?

@cccs-jc
Copy link
Collaborator

cccs-jc commented Sep 10, 2022

@goodwanghan I'm back from vacation. Would you like to discuss integration of our tool into your project?

@surjansr
Copy link

surjansr commented Sep 10, 2022

Are you planning to use the extension as part of another project or use it as is?

Planning to use it as is for now and also to contribute to this super cool project but my contribution will only come after I am approved to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants