From bfd78188750058b0fb2941a3b240de2f93efbb00 Mon Sep 17 00:00:00 2001
From: Maxime Beauchemin <maximebeauchemin@gmail.com>
Date: Sat, 1 Jun 2019 10:19:49 -0700
Subject: [PATCH] [FAB] set AppBuilder to update_perms=False (#7561)

* [FAB] set AppBuilder to update_perms=False

Upon start, by default, FAB tries to go and update the permission list
in the database based on the list of views, models and menu items that
exist in the code.

Really this should happen once per deployment/upgrade and
not in module scope, so we have `superset init` for this.

The intent was always to set to False by default, but I think we forgot
to add this flag back in
https://github.com/apache/incubator-superset/pull/7323

* Add superset init to tox
---
 superset/__init__.py | 1 +
 tox.ini              | 1 +
 2 files changed, 2 insertions(+)

diff --git a/superset/__init__.py b/superset/__init__.py
index 6971dc9d4c8ab..d03f28e627777 100644
--- a/superset/__init__.py
+++ b/superset/__init__.py
@@ -203,6 +203,7 @@ def index(self):
         base_template='superset/base.html',
         indexview=MyIndexView,
         security_manager_class=custom_sm,
+        update_perms=False,  # Run `superset init` to update FAB's perms
     )
 
 security_manager = appbuilder.sm
diff --git a/tox.ini b/tox.ini
index dbe2baaca3aff..8b39058da3df4 100644
--- a/tox.ini
+++ b/tox.ini
@@ -48,6 +48,7 @@ require-code = true
 [testenv]
 commands =
     {toxinidir}/superset/bin/superset db upgrade
+    {toxinidir}/superset/bin/superset init
     nosetests tests/load_examples_test.py
     nosetests -e load_examples_test {posargs}
 deps =