Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TangentFromDSS2DFunctor swap coordinates #1083

Closed
aoblet opened this issue Dec 6, 2015 · 4 comments
Closed

TangentFromDSS2DFunctor swap coordinates #1083

aoblet opened this issue Dec 6, 2015 · 4 comments
Assignees
@copyme
Labels
Geometry
Milestone
0.9.1

Comments

@aoblet
Copy link

aoblet commented Dec 6, 2015

You have swapped the the x and y tangent coordinates here :
https://github.com/DGtal-team/DGtal/blob/master/src/DGtal/geometry/curves/estimation/FunctorsLambdaMST.h#L145

The formula says that "a" is deltaY and "b" is the deltaX of segment slope.
@dcoeurjo dcoeurjo added this to the 0.9.1 milestone Dec 14, 2015
@dcoeurjo
Copy link
Member

Thanks for the bug report. @copyme, could you please have a look to this one ?

@copyme
Copy link
Member

copyme commented Dec 18, 2015

@dcoeurjo I will have a look during these holidays.

@copyme copyme mentioned this issue Jan 11, 2016
Merged
@copyme
Copy link
Member

copyme commented Jan 11, 2016

Fixed in #1107.

@dcoeurjo
Copy link
Member

Fixed. thanks for the bug report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@copyme copyme

Labels
Geometry
Projects
None yet
Milestone
0.9.1
Development

No branches or pull requests
3 participants
@copyme @dcoeurjo @aoblet