Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flip to surface mesh #1702

Merged
merged 24 commits into from
Oct 21, 2023

Conversation

JacquesOlivierLachaud
Copy link
Member

@JacquesOlivierLachaud JacquesOlivierLachaud commented Sep 1, 2023

PR Description

This PR adds methods to flip edges along a SurfaceMesh. Only an edge bordered by two well-oriented triangles can be flipped.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions & appveyor)

@JacquesOlivierLachaud
Copy link
Member Author

/builddoc

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

The documentation is built. It will be available, after a few minutes, here: https://dgtal-team.github.io/doc-nightly/pr1702/index.html

@JacquesOlivierLachaud
Copy link
Member Author

/builddoc

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

The documentation is built. It will be available, after a few minutes, here: https://dgtal-team.github.io/doc-nightly/pr1702/index.html

@JacquesOlivierLachaud
Copy link
Member Author

Everything seems fine. This PR is ready for review.

Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I just have few minor comments.

src/DGtal/shapes/doc/moduleSurfaceMesh.dox Outdated Show resolved Hide resolved
src/DGtal/shapes/doc/moduleSurfaceMesh.dox Show resolved Hide resolved
src/DGtal/shapes/doc/moduleSurfaceMesh.dox Outdated Show resolved Hide resolved
src/DGtal/shapes/SurfaceMesh.ih Outdated Show resolved Hide resolved
src/DGtal/shapes/SurfaceMesh.ih Show resolved Hide resolved
@JacquesOlivierLachaud
Copy link
Member Author

/builddoc

@github-actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://dgtal-team.github.io/doc-nightly/pr1702/index.html

@JacquesOlivierLachaud
Copy link
Member Author

/builddoc

@github-actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://dgtal-team.github.io/doc-nightly/pr1702/index.html

@JacquesOlivierLachaud
Copy link
Member Author

/builddoc

@github-actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://dgtal-team.github.io/doc-nightly/pr1702/index.html

@JacquesOlivierLachaud
Copy link
Member Author

Looks fine now. Waiting for you to resolve conversations.

Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment to clarify the left/right thing. Thanks for the fixes

@JacquesOlivierLachaud
Copy link
Member Author

JacquesOlivierLachaud commented Oct 20, 2023

Weird compile errors on windows due to Conan. Any ideas ? Seems unrelated to PR.

@dcoeurjo
Copy link
Member

One bot has still some weird issue but ready to merge

@dcoeurjo
Copy link
Member

Thx

@dcoeurjo dcoeurjo merged commit d510cc0 into DGtal-team:master Oct 21, 2023
21 of 22 checks passed
@dcoeurjo dcoeurjo deleted the AddFlipToSurfaceMesh branch October 21, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants