-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flip to surface mesh #1702
Add flip to surface mesh #1702
Conversation
…cation of SurfaceMesh
/builddoc |
The documentation is built. It will be available, after a few minutes, here: https://dgtal-team.github.io/doc-nightly/pr1702/index.html |
/builddoc |
The documentation is built. It will be available, after a few minutes, here: https://dgtal-team.github.io/doc-nightly/pr1702/index.html |
Everything seems fine. This PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I just have few minor comments.
/builddoc |
The documentation is built. It will be available, after a few minutes, here: https://dgtal-team.github.io/doc-nightly/pr1702/index.html |
/builddoc |
The documentation is built. It will be available, after a few minutes, here: https://dgtal-team.github.io/doc-nightly/pr1702/index.html |
/builddoc |
The documentation is built. It will be available, after a few minutes, here: https://dgtal-team.github.io/doc-nightly/pr1702/index.html |
Looks fine now. Waiting for you to resolve conversations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment to clarify the left/right thing. Thanks for the fixes
Weird compile errors on windows due to Conan. Any ideas ? Seems unrelated to PR. |
One bot has still some weird issue but ready to merge |
Thx |
PR Description
This PR adds methods to flip edges along a SurfaceMesh. Only an edge bordered by two well-oriented triangles can be flipped.
Checklist