Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testArithmeticalConvexhull enters an infinite loop #997

Closed
dcoeurjo opened this issue Apr 23, 2015 · 4 comments
Closed

testArithmeticalConvexhull enters an infinite loop #997

dcoeurjo opened this issue Apr 23, 2015 · 4 comments
Assignees
Labels

Comments

@dcoeurjo
Copy link
Member

for some specific build configurations only..

see eg. #949

@isivigno
Copy link
Member

May be related to the changes made in #950: @troussil could you have a look at it ?

@rolanddenis
Copy link
Member

For my last PR, I've launch all the tests and they all passed, even the testArithmeticalDSSConvexHull but it was very long, 470s on my computer. It is maybe not an infinite loop ?
In addition, only the travis builds that use gcc failed on this test, but when clang is used, it passed (this test).

I did some tests and here are the corresponding time for this test:

  • g++ (4.9.2), Debug: 470s,
  • g++, Release: 29s,
  • clang++ (3.5.0), Debug: 35s,
  • clang++, Release: 27s.

There seems to be a huge slowdown of this test in debug mode with gcc...

@troussil
Copy link
Member

Thank you @rolanddenis. You're right.

testArithmeticalDSSConvexHull runs in 10 minutes on my computer. @isivigno, you should remove the following line:
https://github.com/isivigno/DGtal/blob/cd73975c50b805ae9b53205c7548cceff4b9649a/tests/geometry/curves/testArithmeticalDSSConvexHull.cpp#L429
because the added loop is too costly.
Without it, the whole test runs in 10 seconds.

PS. g++ (4.8.2), Debug

@dcoeurjo
Copy link
Member Author

Seems to be solved.. closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants