Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voxglitch Groovebox cannot load a folder containing several WAV files, Cardinal VST3 (main) 23.02, REAPER v6.79, Windows 11 #533

Open
GBaige opened this issue Apr 30, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@GBaige
Copy link

GBaige commented Apr 30, 2023

Once again Cardinal VST3 (main) 23.02, REAPER v6.79, Windows 11, issue is not present in VCV Rack 2

Right-clicking on the Voxglitch Groovebox module and clicking on "Load first 8 WAV files from a folder" opens a File Explorer window; however, rather than being able to select the desired folder, the File Explorer instead enters the folder. The user can attempt to load a file inside the folder, but nothing will happen.

this don't fuckin work

@cosinekitty
Copy link
Contributor

@clone45 might want to take a look at this.

@clone45
Copy link

clone45 commented Apr 30, 2023

Thanks! I'm a bit busy right now, but I'll try to address it soon!

@dromer
Copy link
Collaborator

dromer commented Sep 22, 2024

@GBaige latest nightly builds have Voxglitch updated to latest version, can you test again?

[edit: actually I can confirm that it doesn't work ... @clone45 ? :D ]

It does work in VCV. It seems our filebrowser is not selecting folder location but a single file? filebrowser mode seems different. Perhaps something in our async-dialog configuration.

@dromer dromer added the bug Something isn't working label Sep 22, 2024
@clone45
Copy link

clone45 commented Sep 22, 2024

@dromer Certainly, I'll put some time aside tomorrow to dig into this. I appreciate the heads-up.

@dromer
Copy link
Collaborator

dromer commented Sep 22, 2024

Ok this fixes it for me:

diff --git a/src/GrooveBox/GrooveBoxWidget.hpp b/src/GrooveBox/GrooveBoxWidget.hpp
index 1aef45b..65e7a34 100644
--- a/src/GrooveBox/GrooveBoxWidget.hpp
+++ b/src/GrooveBox/GrooveBoxWidget.hpp
@@ -62,7 +62,8 @@ struct LoadSamplesFromFolderMenuItem : MenuItem
         async_dialog_filebrowser(false, NULL, module->samples_root_dir.c_str(), "Load folder", [module](char *path)
                                  {
                        if(path){
-                               pathSelected(module, std::string(path));
+                               std::string dir = system::getDirectory(path);^M
+                               pathSelected(module, dir);^M
                                free(path);
                        } });
 #else

This the step you meant from chat @falkTX ?

@falkTX
Copy link
Contributor

falkTX commented Sep 22, 2024

yes, but that 2nd line can be simplified since "dir" is already a std::string type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants