Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage statistics - differentiating between the test plans and real plans #2158

Closed
magdalenadrafiova opened this issue Jun 11, 2019 · 10 comments

Comments

@magdalenadrafiova
Copy link

Currently the usage statistics dashboard does not differentiate between the test plans and the real plans. Could we differentiate these for the administrators?

Let me know if you need more detail about this.

@briri
Copy link
Contributor

briri commented Jun 11, 2019

Yes. It is easy for us to determine which of the plans are 'test'. Do we prefer to exclude them entirely from the statistics calculations or just indicate how many of the total number of plans are 'test'?

@magdalenadrafiova
Copy link
Author

magdalenadrafiova commented Jun 11, 2019 via email

@sjDCC
Copy link
Contributor

sjDCC commented Jun 18, 2019

We don't need lots of detail on test plans so exclude from total statistics. If we include anything on test plans just a total number is sufficient

Check whether we need to run a new rake task for old stats or see if it does this automatically

@sjDCC
Copy link
Contributor

sjDCC commented Nov 15, 2019

Make it a toggle so people can see both stats

@mariapraetzellis
Copy link

Add a checkbox which is defaulted to ticked to include test plans in stats.
Allow org admins to untick the box
Add text to show total plan figure to show this includes test as shown in screenshot below:

screenshot-dmptool org-2020 01 09-14_14_43

@sjDCC
Copy link
Contributor

sjDCC commented Jan 14, 2020

Suggestion from @xsrust that we may need two stats tables - one with test and one without

May be best to word it as 'exclude test plans' from count so overall

Alternatively say total number of test in parenthesis so we don't have to build in new functionality and logic

@xsrust
Copy link
Contributor

xsrust commented Jan 14, 2020

If it's possible to have a number of test plans in each statistic so we can re-compute the totals with/without tests rather than double the entries in the stats table

@sjDCC
Copy link
Contributor

sjDCC commented Jan 16, 2020

Have validated with @mariapraetzellis and this approach is fine

@xsrust xsrust self-assigned this Apr 14, 2020
@sjDCC
Copy link
Contributor

sjDCC commented Jun 10, 2020

Couldn't propogate test plan filters through to click-through pagination of results per month

Numbers generating for stats weren't discounting inactive plans but Rails counts are. This leads to a discrepancy between historical data and what may be showing now e.g. is a user has deleted plan since

@sjDCC
Copy link
Contributor

sjDCC commented Jun 10, 2020

Looks good. Easy to use filter and don't think anyone would notice discrepancy between numbers in graph and in click through. We already alert this is historical data

Closing out. Thanks @xsrust

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants