Check new one-click plan creation feature from OPIDoR

[sjDCC]

No description provided.

[sjDCC]

This looks good, but I encountered a few issues:

1. It's not obvious to the user what the buttons do and the hovertext and accessibility note overlap. Should we rename the column "Create plan"
   

2. When I click to create a plan or copy the link into a new window, I get the right pop-up notification but clicking "Yes" doesn't work. A new window opens instead. No plan is created.
   

[briri]

thanks @sjDCC will have a look at this today

[briri]

I updated the column header to read 'Create a new plan' and added a tooltip for the copy icon that reads 'Copy link to create a new plan'.

@sjDCC the overlap with the 'opens in a new window' and the create plan confirmation window appear to be specific to DMPonline. I cannot repeat them with the vanilla Roadmap code. Here are the screenshots of what I'm seeing:

The tooltips (no 'opens in a new window' appearing)

The modal window that opens when I click the 'Copy link icon' (Note the new column heading)

[benjaminfaure]

Thank you for your feedback @sjDCC.
If we contribute again in the near future, I will try to pay more attention to the accessibility. We mostly rely on the work you did :) .
Do you have some guidelines that we could follow, something that you could put in the Contribute wiki page maybe ? (If it's not already there !)

[sjDCC]

Don't worry @benjaminfaure I think these accessibility features are new so you won't have seen them. They're not deployed yet.

@briri Thanks for the change to the column title - looks good. We're you deploying from -dev as those accessibility features should be common, not specific to DMPonline branding. And were you getting an issue with popup not generating a plan? @xsrust could you check if anything is down to our deployment

[briri]

@benjaminfaure we will try to write up some accessibility guidelines in the near future

@sjDCC I was running against the development branch.

@xsrust Those 'opens in a new window' messages look like they will only appear if the link will send you to a different domain, so I'm not sure why @sjDCC was seeing that.

[raycarrick-ed]

Seems to be down to an error in getting the current HOSTNAME in app/views/layouts/application.html.erb. Then the link is checked against this value to see if the link is local or not. If it isn't local then it gets opened in a new window but since it always thinks everything is non local .........

[mariapraetzellis]

This may have a one-line bug but would be a quick fix. Waiting till the New Year to review with Sam.

[sjDCC]

@raycarrick-ed to check the one-line hostname fix is in and then move to UAT

[mariapraetzellis]

@sjDCC and @magdalenadrafiova to do UAT on multi-tenant sites and close out

[magdalenadrafiova]

@xsrust I am not sure whether I am looking at the right thing - but it seems I am missing loads of things Sarah can see

[magdalenadrafiova]

https://dmponline-dev.dcc.ac.uk/public_templates > the page opens well

& when I click on create a new plan a new window opens

works well closing this