Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS news feed is broken #2411

Closed
benjaminfaure opened this issue Feb 27, 2020 · 3 comments
Closed

RSS news feed is broken #2411

benjaminfaure opened this issue Feb 27, 2020 · 3 comments
Labels

Comments

@benjaminfaure
Copy link
Contributor

Hello everyone,

DMP OPIDoR have been using the RSS feed for our own news. It seems to be broken since Feedjira 3.0.
The Feed.fetch_and_parse method has been removed in this version.

def about_us
dcc_news_feed_url = "http://www.dcc.ac.uk/news/dmponline-0/feed"
@dcc_news_feed = Feedjira::Feed.fetch_and_parse dcc_news_feed_url
respond_to do |format|
format.rss { redirect_to dcc_news_feed_url }
format.html
end
end

There is two ways of fixing this :

  1. Fixing the gem version to V2.2.0
  2. Include the HTTParty gem and change the code as shown in the README : https://github.com/feedjira/feedjira/blob/master/README.md

I tested the second solution, it seems to work without too much changes.
Should I send you a PR ?

@briri
Copy link
Contributor

briri commented Feb 27, 2020

Thanks for catching that @benjaminfaure
I just took a look and noticed that the RSS feed isn't even used anymore on that un-branded about_us page. I submitted a PR #2412 to remove Feedjira and that code block

@mariapraetzellis
Copy link

@briri are we good to close this issue?

@briri
Copy link
Contributor

briri commented Jun 22, 2020

yes. thanks

@briri briri closed this as completed Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants