New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

orgs_controller#shibboleth_ds view expects list of Org, not Identifier #2686

Closed

nicolasfranck opened this issue Sep 16, 2020 · 1 comment

Contributor

nicolasfranck commented Sep 16, 2020

Please complete the following fields as applicable:

Expected behaviour:

Actual behaviour:

orgs_controller#shibboleth_ds selects a list of Identifier and stores it in @orgs
(which crashes btw because it cannot sort on name): https://github.com/DMPRoadmap/roadmap/blob/master/app/controllers/orgs_controller.rb#L92
app/views/orgs/shibboleth_ds.html.erb uses @orgs as if they are organisations ("Select your organisation")

Unused code?

Steps to reproduce:

checkout version 2.2.0
logout
make sure there are Identifier of type Org and scheme shibboleth
go to /orgs/shibboleth

The text was updated successfully, but these errors were encountered:

nicolasfranck mentioned this issue

@orgs should be orgs; use shib-ds[org-id] #2753

Merged

Contributor

briri commented Dec 17, 2020

fixed and will be included as part of v3.0.1

briri closed this as completed

briri mentioned this issue

Bug fixes and a few maDMP features for v3.0.1 #2769

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment