Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Link credentials" on profile page opens a new window #2752

Closed
nicolasfranck opened this issue Dec 2, 2020 · 2 comments
Closed

"Link credentials" on profile page opens a new window #2752

nicolasfranck opened this issue Dec 2, 2020 · 2 comments

Comments

@nicolasfranck
Copy link
Contributor

Please complete the following fields as applicable:

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)

3.0.0

Actual behaviour:

The links "link to your orcid" or "link your institutional credentials" are opened
in a new window where all authentication happens, and after a successfull login
you're redirected to your profile page.

But meanwhile there is still an outdated profile page open. Confusing?

I've seen this behaviour in applications that use this technique to shield
themselves from the authentication layer, but at the end of the authentication
a piece of javascript sends a signal to the opening page, and closes itself.
But that is not the case here.

@xsrust
Copy link
Contributor

xsrust commented Dec 2, 2020

That seems to be an un-intended consequence of an accessibility feature that was added to signal to end-users when following a link would take them away from the domain where DMPRoadmap is hosted.

The best way to fix this is likely to create an opt-out for the "opens in new window" text/behavior and apply it to both of these links.

@briri
Copy link
Contributor

briri commented Dec 17, 2020

fixed and will be part of the v3.0.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants