Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting for "Public DMPs" PDF files #712

Closed
stephaniesimms opened this issue Oct 12, 2017 · 11 comments
Closed

Fix formatting for "Public DMPs" PDF files #712

stephaniesimms opened this issue Oct 12, 2017 · 11 comments
Assignees
Labels

Comments

@stephaniesimms
Copy link

stephaniesimms commented Oct 12, 2017

related issue #436 (closed but referenced here just in case)

On the cover page:

  • Change "Funder" to "Template" (since not all templates are based on funder reqs)
  • Change "Last updated" to "Last modified"
  • IF info was provided in either field by user, include "Grant ID" and/or "Project abstract" between "Template" and "Last modified"

screen shot 2018-01-05 at 9 06 22 am

On the plan pages that follow the cover page:

  • The Project Title should appear at the top of the first page (replace "Data Management Plan" with the Project Title in screenshot below)
  • Display Section headings but NOT Questions - this creates too much clutter; users can export the template if they want to see all the question detail (remove second line of boldface text, e.g. "Types of data, samples, physical...")

screen shot 2018-01-05 at 9 06 40 am

@stephaniesimms stephaniesimms added this to the Create plan workflow milestone Oct 12, 2017
@stephaniesimms stephaniesimms changed the title Fix formatting for downloaded plans PDF and DOCX Fix formatting for "Public DMPs" PDF and DOCX files Jan 5, 2018
@stephaniesimms stephaniesimms changed the title Fix formatting for "Public DMPs" PDF and DOCX files Fix formatting for "Public DMPs" PDF files Jan 5, 2018
@briri briri self-assigned this Jan 19, 2018
@briri
Copy link
Contributor

briri commented Jan 19, 2018

@stephaniesimms I updated the cover page according to your instructions above. The layout of the abstract though looked strange since it contains HTML and did not display nicely (multiple lines, tables, lists, etc.). To solve this issue I bumped it down below the 'Project abstract:' label and indented it. I did the same with the longer 'Copyright information:' section as well to keep things consistent.

Let me know if that's ok or you'd like to take a different approach
screen shot 2018-01-19 at 2 19 07 pm

@briri
Copy link
Contributor

briri commented Jan 19, 2018

Updated the answers page as well (see screenshot) the 'Data Management Plan' text was the name of the phase for the template you were testing (we used that as a default during our data migration). I have updated it to show the 'project title' or 'project title - phase title' if the template has multiple phases (e.g. Horizon2020)

screen shot 2018-01-19 at 2 26 30 pm

@stephaniesimms
Copy link
Author

stephaniesimms commented Jan 19, 2018

I think your solution for the abstract looks good and agree re indenting the copyright statement too. I just want to test w/bullets, italics, other formatting to make sure it doesn't go wonky (or let me know if you already did so @briri ). the answers page looks good too.

two small changes:

  • can you switch to a sans serif font, ideally the same we use for PDF export?
  • remove period at the end of the line on cover page "A DMP created using DMP Roadmap"

@stephaniesimms
Copy link
Author

content looks good @briri - i just have the same minor formatting requests as those for DMP Templates in #1003

  • set 1 inch margins for both file types. currently the margins are too small and, e.g., text encroaches on the footer.
  • if possible, insert line breaks b/w headings and text. also need line breaks b/w paragraphs when there are long sections of guidance.

@briri
Copy link
Contributor

briri commented Jan 23, 2018

I'm not going to be able to insert line breaks within long sections of text @stephaniesimms since we just show whatever the user has entered in the answer/question/guidance through the tool.

@stephaniesimms
Copy link
Author

i didn't want to or expect that we could mess w/formatting for user-provided text @briri - it's just hard to tell the root cause of various formatting issues (user or text editor/html weirdness). we can standardize the template and question formatting though i hope.

@briri
Copy link
Contributor

briri commented Jan 24, 2018

Glad to hear it @stephaniesimms :)
I'm able to format the PDFs as requested. I was able to do the same with the DOCX files to some extent. I cannot seem to manipulate the indentation of any of the text in DOCX unless we start using a different gem

@stephaniesimms
Copy link
Author

overall PDF formatting is looking good @briri . after some more testing and comparison w/DMPTool I have more changes to request:

  • reduce left and right margins slightly (whatever they are on DMPTool is good) to fit more text on the page
  • reduce font size for answer text (again whatever we use for DMPTool is a nice guide)
  • revise footer text and remove it from the cover page. page 1 should be the first page of the plan, after the cover page. new text: "Created using the %ApplicationName%. Last modified %Date%"
  • i like the lines we use at top and bottom of cover page and plan pages for DMPTool (screenshot). if it's not too fussy, please add them here. at minimum we should add a line to separate the footer.

screen shot 2018-01-24 at 3 12 44 pm

screen shot 2018-01-24 at 3 12 59 pm

@stephaniesimms
Copy link
Author

stephaniesimms commented Feb 1, 2018

two small change requests @briri -

  • revise footer text: "Created using the %ApplicationName%. Last modified %Date%" (just date, no time per changes requested for DMP Template footer)
  • if possible, page 1 should be the first page of the plan, after the cover page

@stephaniesimms
Copy link
Author

there's a funny line in the middle of the NSF EAGER PDF but that appears to be bad/old data. downloading newly created public plans looks good. closing issue.

@sjDCC
Copy link
Contributor

sjDCC commented Feb 13, 2018

I got these lines too in Jose's plan and the COMET one I've just published - I think it's the border for top and bottom of page floating elsewhere.

I created a completely new plan though and the lines were where they should be so assuming it's applying this to old data. Removing from board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants