-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix formatting for "Public DMPs" PDF files #712
Comments
@stephaniesimms I updated the cover page according to your instructions above. The layout of the abstract though looked strange since it contains HTML and did not display nicely (multiple lines, tables, lists, etc.). To solve this issue I bumped it down below the 'Project abstract:' label and indented it. I did the same with the longer 'Copyright information:' section as well to keep things consistent. Let me know if that's ok or you'd like to take a different approach |
Updated the answers page as well (see screenshot) the 'Data Management Plan' text was the name of the phase for the template you were testing (we used that as a default during our data migration). I have updated it to show the 'project title' or 'project title - phase title' if the template has multiple phases (e.g. Horizon2020) |
I think your solution for the abstract looks good and agree re indenting the copyright statement too. I just want to test w/bullets, italics, other formatting to make sure it doesn't go wonky (or let me know if you already did so @briri ). the answers page looks good too. two small changes:
|
content looks good @briri - i just have the same minor formatting requests as those for DMP Templates in #1003
|
I'm not going to be able to insert line breaks within long sections of text @stephaniesimms since we just show whatever the user has entered in the answer/question/guidance through the tool. |
i didn't want to or expect that we could mess w/formatting for user-provided text @briri - it's just hard to tell the root cause of various formatting issues (user or text editor/html weirdness). we can standardize the template and question formatting though i hope. |
Glad to hear it @stephaniesimms :) |
overall PDF formatting is looking good @briri . after some more testing and comparison w/DMPTool I have more changes to request:
|
two small change requests @briri -
|
there's a funny line in the middle of the NSF EAGER PDF but that appears to be bad/old data. downloading newly created public plans looks good. closing issue. |
I got these lines too in Jose's plan and the COMET one I've just published - I think it's the border for top and bottom of page floating elsewhere. I created a completely new plan though and the lines were where they should be so assuming it's applying this to old data. Removing from board. |
related issue #436 (closed but referenced here just in case)
On the cover page:
On the plan pages that follow the cover page:
The text was updated successfully, but these errors were encountered: