clicking on a tab makes the page jump to the top

[briri]

Please complete the following fields as applicable:

Expected behaviour:
Clicking on a tab does not cause the page to jump to the top. If we need to reorient the window we should scroll to the top of a designated container/div (defaulting to the parent container)

Actual behaviour:
Clicking on a tab in the write plan's section's quidance/comments makes the page jump to the top. This is particularly annoying when working with sections at the bottom or if all sections happen to be expanded

[stephaniesimms]

@briri I can't test this because I get the following error. the error occurs if I select any extra guidance on the Project Details page and then click on the Write Plan tab. there is no error if I leave the guidance blank and navigate to Write Plan.

also, the desired behavior is for any Org affiliation and the DCC/default guidance tickboxes (first two) to be checked by default on Project Details page. i can create a separate issue for this if not appropriate to address here.

[briri]

will address this bug with loading the page. there is another ticket in progress #943 that involves finishing the implementation of the guidance tickboxes on the project details page.

[stephaniesimms]

the tab behavior is working as expected now. but I'm having problems expanding/collapsing the accordions within tabbed guidance. one example is that when i click the + to expand the guidance next to Q2 in the screenshot below it activates/expands the same section beside Q1. regardless of which accordion I click I can only expand/collapse Q1. the same appears to be happening from one section to another. when I attempt to expand guidance in lower sections it activates this same area next to Section 1: Q1 or doesn't do anything at all. this seems to be happening at random and/or I can't expand most accordions w/themed guidance.

desired behavior is to be able to expand any individual piece of guidance regardless of whether others are open or closed.

[stephaniesimms]

@briri i can't test this at the moment - there appears to be a bug w/displaying guidance in tabs. not sure if it's related to this issue or #944 (more details in that issue)

[sjDCC]

The page no longer jumps to the top, which is great - thanks @bhavi The zip up/down of guidance is still problematic for me though. Often the second or third theme won't expand. Clicking these just changes the first (opens if closed or zips it up if open). The expand all opens all in most cases but I had a legacy plan where this button wouldn't do anything. The later theme wouldn't open either.

When will #944 be done? At present the organisational guidance is not being selected as default as it should based on selections in create plan wizard. I think we need to re-test this when the guidance is being applied correctly.

[stephaniesimms]

i thought the issues with displaying and expanding tabbed guidance were resolved @briri - when i created some new plans and tested the guidance selections and display behavior it all worked as expected. but after moving on to test other guidance issues it's jumping to the top when i click on some tabs, and not others...

i'll leave this here for @sjDCC to test some more and see if she can discern a pattern to the jumping issues. the accordions all seem to work. but sometimes clicking on tabs is wonky.

[stephaniesimms]

this still seems to be affected by related guidance issues in #944 - wait and test these two issues together

[sjDCC]

The tabs all seem to be working fine now. Closing out but leaving on board for @stephaniesimms to verify