Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why SPDM responder read the requester certificate chain directly in negotiate state ? #286

Open
owen126315 opened this issue Aug 23, 2023 · 1 comment
Labels
question Further information is requested

Comments

@owen126315
Copy link

res = libspdm_read_requester_root_public_certificate(
m_use_hash_algo, m_use_req_asym_algo, &data,
&data_size, &hash, &hash_size);
libspdm_x509_get_cert_from_cert_chain(
(uint8_t *)data + sizeof(spdm_cert_chain_t) + hash_size,
data_size - sizeof(spdm_cert_chain_t) - hash_size, 0,
&root_cert, &root_cert_size);
if (res) {
libspdm_zero_mem(&parameter, sizeof(parameter));
parameter.location = LIBSPDM_DATA_LOCATION_LOCAL;
libspdm_set_data(
spdm_context,
LIBSPDM_DATA_PEER_PUBLIC_ROOT_CERT,
&parameter, (void *)root_cert, root_cert_size);
/* Do not free it.*/
}

Should the responder get the requester certificate chain through mutual authentication, instead of file read it directly?

@jyao1
Copy link
Member

jyao1 commented Aug 25, 2023

Read local == provision.
Read peer == runtime check.

@jyao1 jyao1 added the question Further information is requested label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants