New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should not use interface_id from requester in get_version #300

Open

jyao1 opened this issue Nov 6, 2023 · 0 comments

Assignees

Member

jyao1 commented Nov 6, 2023

Current TDISP sample code uses interface_id in the get_version message.
See https://github.com/DMTF/spdm-emu/blob/main/library/pci_tdisp_device_lib_sample/pci_tdisp_device_version.c#L41

It is wrong, because it assumes the first time interface_id is correct.

I think libtdisp_initialize_interface_context() should be called earlier, in device initialization phase. But not get_version.

jyao1 self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment