Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert accented characters on post URLs #203

Open
fkw opened this issue Feb 7, 2023 · 8 comments
Open

Convert accented characters on post URLs #203

fkw opened this issue Feb 7, 2023 · 8 comments

Comments

@fkw
Copy link

fkw commented Feb 7, 2023

Could work with the DNN setting :

image

At the moment it's only converting to lowercase, without spaces.

@WillStrohl
Copy link
Member

Thank you for reporting this potential issue.

  • What version of DNN and Blog module are you running?
  • Do you also see any errors related to the issue by any chance?

Also, while it might seem completely straightforward to you, it would be very helpful for anyone willing to write code to fix anything if you could provide clear steps to reproduce the issue.

@valadas
Copy link
Member

valadas commented Feb 7, 2023

Yeah, not the clearest of issues, can you explain a bit more what you mean here... The setting you are talking about I believe is a DNN setting for page URLs, what's wrong with accented characters in titles ?

@fkw
Copy link
Author

fkw commented Feb 8, 2023

It's not a big issue, but the website I'm working on is tracked by an SEO agency. Accentless URLs are better for SEO. Also, a copy/paste of a URL with accents encodes the URL (%C3%A9 for é for example), not very clean.
DNN 9.10
Blog 6.5.2

@valadas
Copy link
Member

valadas commented Feb 8, 2023

Ok, so it's not the title, it's the blog post detail friendly URL ?

@valadas
Copy link
Member

valadas commented Feb 8, 2023

It really helps to understand to use the issue-reporting template with things developers need to know like the steps to reproduce and the current vs expected behaviours... Makes issues like this one way more clear...

@fkw fkw changed the title Convert accented characters on page titles Convert accented characters on post URLs Feb 9, 2023
@fkw
Copy link
Author

fkw commented Feb 9, 2023

Ok, so it's not the title, it's the blog post detail friendly URL ?

Yep, sorry it's the URL, I've just edited my post title...

@WillStrohl
Copy link
Member

Would you be able to edit the post to include a consistent set of steps to reproduce the issue, please? :)

@fkw
Copy link
Author

fkw commented Feb 13, 2023

Not really...
The only thing I can say is that posts URLs are converted to lowercase, in the same way that DNN converts the URLs of pages.
As there is DNN SEO settings to convert URLs (see screenshot on the first post), I thought it could also convert accented characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants