Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTL limits not honored #1654

Closed
ghost opened this issue Mar 30, 2021 · 1 comment
Closed

TTL limits not honored #1654

ghost opened this issue Mar 30, 2021 · 1 comment

Comments

@ghost
Copy link

ghost commented Mar 30, 2021

Starting from 2.0.45 TTL limits in the TOML aren't properly honored anymore:

If one resolves a domain and then sends a 2nd query during the cache period the actual TLL can be much longer then the expected one, actually up to twice as long.
E.g. resolve 'github.com' with default TOML says it has a 40min TTL. Now send a 2nd query after 39min, so it's served from the cache, again having a TTL of 40min. You end up with an actual TTL of 39min + 40 min = 79min, instead of the intended 40 min.

If that's the new intended behaviour, you should rename TTL (e.g. TTBC = time to be cached) to avoid confusion and lower the current TTL values in the TOML. We then would also need a new way how to limit the actual TTL.

Verified on Windows and Linux. Not tested, but Mac treats TTL differently, right?

This is a direct consequence of bug #1624.

Ah, and btw. there's still one mention of the term 'whitelisting' in 'dnscrypt-proxy.log' when using an allowed-names list.

@jedisct1
Copy link
Member

Can you please open a discussion about this first?

Thank you.

@DNSCrypt DNSCrypt locked and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant