-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1주차 기본/심화 과제] 가계부 💸 #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋은 코드 잘 봤습니다! 역시나 이번에도 너무나도 깔끔하게 잘 만드셔서 제가 딱히 리뷰 드릴 게 없었습니다 😄
또 한 번 말씀드리지만 제 review는 저의 의견일 뿐 객관적인 지표는 아닐 수 있으니 이 점 유념해 주시면 감사드리겠습니다 :)
|
||
margin: 2.5rem 0; | ||
padding-bottom: 2rem; | ||
margin-bottom: 4rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
margin: 2.5rem 0 4rem;
이렇게 축약 시킬 수 있을 거 같습니다!
<div class="date"> | ||
<button type="button"><</button> | ||
<span>10월 13일</span> | ||
<button type="button">></button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'>'는 종료 태그와 헷갈릴 수 있는데 HTML entity에 대해선 어떻게 생각하시나요??
참고자료
왜 HTML entity를 사용해야 하죠? : https://teamtreehouse.com/community/why-dont-we-just-put-instead-of-writing-gt
HTML entity : https://www.freeformatter.com/html-entities.html
/* list */ | ||
ol { | ||
margin-top: 5rem; | ||
padding-bottom: 5rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
padding-bottom: 5rem; | ||
} | ||
|
||
li { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
다시 한 번 말하는 감자인 점 사죄드리며,, 너무 깔끔하게 잘하신 것 같아용!
|
||
overflow-y: scroll; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sub-menu를 포함한 전체에다 스크롤을 주지 않고 sub-menu를 뺀 리스트 부분에만 스크롤을 주면 더 좋을 것 같아요! 그래야 스크롤 하다가 수입 , 지출을 선택하려고 다시 스크롤해서 올라가지 않아도 되니 편할 것 같습니당
배포링크
✨ 구현 기능 명세
기본 과제
심화 과제
💎 PR Point
시맨틱 태그
div 안쓰는거 대체 어떻게 하는건데...체크박스 커스텀
🥺 소요 시간, 어려웠던 점
1h
🌈 구현 결과물
배포링크