Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Unit of N0 in the "Noise" Section of Debugger? #88

Open
SaberCF opened this issue Feb 7, 2023 · 2 comments
Open

Wrong Unit of N0 in the "Noise" Section of Debugger? #88

SaberCF opened this issue Feb 7, 2023 · 2 comments

Comments

@SaberCF
Copy link

SaberCF commented Feb 7, 2023

I found that the unit of N0 in "Noise" section is dB/Hz, and I think it should be dBm/Hz, just like the N0 in the "Min Link Channel Noise Power" below.

GUILayout.Label($"N0: {data.N0:F2}dB/Hz");

@SaberCF
Copy link
Author

SaberCF commented Feb 7, 2023

Well, the "Min Link Channel Noise Power" seems also have some faults.
The two "dB" in {RATools.LogScale(data.minSymbolRate):F1} dB and {channelNoise:F1} dB" should be "dBm" I think.
The unit of "Channel Noise power" in the "Min Link Eb/N0" below is "dBm".

GUILayout.Label($"Min Link Channel Noise Power = N0 ({data.N0:F1} dBm/Hz) * Bandwidth ({RATools.PrettyPrint(data.minSymbolRate)}Hz ({RATools.LogScale(data.minSymbolRate):F1} dB)) = {channelNoise:F1} dB");

GUILayout.Label($"Min Link Eb/N0 = RxPower ({data.rxPower:F1} dBm) - Channel Noise Power ({channelNoise:F1} dBm) - Margin ({encoder.RequiredEbN0:F1} dB) = {data.rxPower - channelNoise - encoder.RequiredEbN0:F1}");

@DRVeyl
Copy link
Owner

DRVeyl commented Feb 12, 2023

Appears I was a little sloppy with units in crafting the debugger. Thanks for the dimensional analysis. I'll keep this open and make a change on next release... which has no timeline currently. [Maybe if Egg's Skopos gets some progress, he has some things he wants to PR, and I might return enough for another bugfix update and merge his things.]

You're correct, N0 will be dBm/Hz. Channel noise power should be dBm. Line 129 looks correct. Line 127 I will keep minSymbolRate in dB [it's just the log scale of the bandwidth] but channelNoise at the very end is dBm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants