Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue With Dataset library in deeprobust for Setting as prognn and for Windows Platform. #136

Open
ratnadeepdas97 opened this issue Apr 2, 2023 · 2 comments

Comments

@ratnadeepdas97
Copy link

Hi Team,

I found an issue in the dataset.py file found in the path deeprobust-0.2.8\deeprobust\graph\data which is used when we call Dataset class like
from deeprobust.graph.data import Dataset

This class does not run, when the setting is done as 'prognn' and run on Windows. It throws and error saying that the Dataset has no attribute 'root'.

Error Screenshot -

Error message
This bug is because of the following code in line 67 as below

if platform.system() == 'Windows':
root = root
else:
self.root = osp.expanduser(osp.normpath(root))

Code Screenshot -

Code

Instead this bug is fixed after a minor modification in the code as

if platform.system() == 'Windows':
self.root = root
else:
self.root = osp.expanduser(osp.normpath(root))

I would like to request to take notice of it.

Thanks,
Ratnadeep

@ratnadeepdas97
Copy link
Author

@ChandlerBang I raised this issue over a month ago. But no response on it yet?

@ChandlerBang
Copy link
Collaborator

Sorry that I was busy with job search. Thank you for the comments and I just resolved this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants