Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve flinksql highlighting #58

Merged
merged 1 commit into from
Oct 30, 2023
Merged

feat: improve flinksql highlighting #58

merged 1 commit into from
Oct 30, 2023

Conversation

HaydenOrz
Copy link
Collaborator

简介

优化 flinksql 高亮功能（目前只做了语言设置部分，theme 相关后续 PR 实现） #55 #26

优化后的效果

image

@HaydenOrz HaydenOrz added the improvement Improve existing feature label Oct 30, 2023
@HaydenOrz HaydenOrz changed the title feat: improve flinksql highlight feat: improve flinksql highlighting Oct 30, 2023
@liuxy0551
Copy link
Collaborator

关键词变化的很多吗，还是说只是调换了位置

@HaydenOrz HaydenOrz self-assigned this Oct 30, 2023
@HaydenOrz
Copy link
Collaborator Author

关键词变化的很多吗，还是说只是调换了位置

关键词变化 关联 PR DTStack/dt-sql-parser#195

@liuxy0551
Copy link
Collaborator

+1

1 similar comment
@mumiao
Copy link
Collaborator

mumiao commented Oct 30, 2023

+1

@mumiao mumiao merged commit c204a2c into DTStack:main Oct 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cythia828 Cythia828 Awaiting requested review from Cythia828

@mumiao mumiao Awaiting requested review from mumiao

@liuxy0551 liuxy0551 Awaiting requested review from liuxy0551

@LuckyFBB LuckyFBB Awaiting requested review from LuckyFBB

Assignees

@HaydenOrz HaydenOrz

Labels
improvement Improve existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HaydenOrz @liuxy0551 @mumiao