Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cubemap probes placement/lookup is incorrect #1257

Closed
VReaperV opened this issue Aug 23, 2024 · 2 comments · Fixed by #1355
Closed

Cubemap probes placement/lookup is incorrect #1257

VReaperV opened this issue Aug 23, 2024 · 2 comments · Fixed by #1355

Comments

@VReaperV
Copy link
Contributor

#1256 (comment):

The cubemap search function can only find probes that are in the same epsilon X epsilon X epsilon-sized voxel. 0.01 is unreasonably small so I assume it was inverted by mistake. 100 is still too small for it to find one the majority of the time though. Overall the code really doesn't make any sense, since the probes are generated in an irregularly spaced way according to BSP nodes, but the lookup code seemingly expects them to be evenly spaced like the light grid, or at least placed with a minimal density.

This should be evaluated at some point, but the cubemap reflections themselves should be fixed first.

@VReaperV
Copy link
Contributor Author

Here's an example of how the current placement works on plat23:
unvanquished_2024-09-17_124109_000
unvanquished_2024-09-17_124037_000
unvanquished_2024-09-17_124029_000
unvanquished_2024-09-17_124020_000

@VReaperV VReaperV added the T-Bug label Sep 20, 2024
@VReaperV VReaperV changed the title Cubemap probes placement/lookup might be incorrect Cubemap probes placement/lookup is incorrect Sep 20, 2024
@VReaperV
Copy link
Contributor Author

This will be fixed once #1355 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant