Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic light blockiness (tile edges visible) #791

Closed
slipher opened this issue Jan 30, 2023 · 1 comment · Fixed by #1108
Closed

Dynamic light blockiness (tile edges visible) #791

slipher opened this issue Jan 30, 2023 · 1 comment · Fixed by #1108
Labels
A-Renderer T-Improvement Improvement for an existing feature

Comments

@slipher
Copy link
Member

slipher commented Jan 30, 2023

Using the tiled renderer, the area covered by a dynamic light can have visible, blocky edges. The issue can be observed by firing a single pulse rifle shot. Here's a screenshot by illwieckz: light blockiness

The tiled lighting works in two phases:

  1. In the lighttile shader, compute the set of lights which is believed to affect each tile. The assumption is that tiles sufficiently far away should be close enough to completely dark not to matter.
  2. When rendering a surface, apply each light in the list for the relevant tile.

It seems that the assumption in (1) is wrong and some of the tiles considered to be not affected actually would have had a significant amount of light. Two obvious approaches to fix this:
(a) Change the calculation of which tiles are affected to rule in more tiles
(b) Change the falloff curve of brightness vs. distance so that the brightness is actually close enough to 0 at the edges

@DolceTriade
Copy link
Contributor

Would be really amazing to fix this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Renderer T-Improvement Improvement for an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants