Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canary/ social callback url #466

Closed
remicastaing opened this issue Aug 20, 2014 · 2 comments
Closed

canary/ social callback url #466

remicastaing opened this issue Aug 20, 2014 · 2 comments
Labels
bug

Comments

@remicastaing
Copy link
Contributor

Something is weird. With:

callbackURL:  process.env.DOMAIN || '' + '/auth/facebook/callback'

I get: http://localhost:9000

I had to add some parenthesis to get it work:

callbackURL:  (process.env.DOMAIN || '') + '/auth/facebook/callback'
@kingcody
Copy link
Member

Nice catch @remicastaing. You are correct. JavaScript Operator Precedence

@kingcody kingcody mentioned this issue Aug 21, 2014
Merged
@remicastaing remicastaing mentioned this issue Aug 23, 2014
Closed
@JaKXz JaKXz added the bug label Aug 23, 2014
@gintsgints
Copy link
Contributor

Huhh.. this helped me lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@remicastaing @gintsgints @kingcody @JaKXz