Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth) add confirm password to signup and settings #484

Closed
wants to merge 1 commit into from

Conversation

thomporter
Copy link

confirm password powered by directive: https://github.com/wongatech/angular-confirm-field
also adding for attribute to labels and ids to associated elements
also fixing invalid password error in settings HTML to ref pwd.old. instead of form.password.
(Jade was ok)

take note of new dependency in test/fixtures/bower.json (re-run bower install on current clones...)

@JaKXz
Copy link
Collaborator

JaKXz commented Aug 25, 2014

👍

@thomporter
Copy link
Author

this was passing on my system locally (a full test on the generator, not just testing a generated app.) But then I merged all of the upstream commits in canary, and now it doesn't work locally either. I call fowl! 🐦

BAH! See my comment here: thomporter@a5977c6

@kingcody
Copy link
Member

@thomporter take a look at my build 35 on travis. I believe I encountered the same error you did. Not terribly sure if I understand why, but @DaftMonk's most recent commit to canary cleared it up for me...

You should be able to git checkout canary && git rebase upstream/canary && git push -f

confirm password powered by directive: https://github.com/wongatech/angular-confirm-field
+ adding for attribute to labels and ids to associated elements
+ fixing invalid password error in settings HTML to ref pwd.old. instead of form.password...
  (Jade was ok)

take note of new dependency in test/fixtures/bower.json (re-run bower install on current clones...)
@thomporter
Copy link
Author

Awesome. That fixed it online! 😄

But it is still failing locally w/ the same errors... 😦

I removed node_modules and bower_components from test/fixtures/, re-ran npm install && bower install from there as well, no luck. Then I tried removing the generator's main node_modules folder, re-running npm install and then npm test but still, it failed. I even re-cloned from my fork to a new folder and tried running the tests there, still failing... 😑

@kingcody
Copy link
Member

Are you getting the same error as you were on travis?

@thomporter
Copy link
Author

yup

@kingcody
Copy link
Member

It would seem that your canary branch is still missing the commit I referred to earlier. Anything I might be able to help with?

@thomporter
Copy link
Author

Strange. I rebased again, and it's working... Why didn't it work locally the first time, the rebase obviously fixed it for Travis online... 😕

@thomporter
Copy link
Author

Anything I can do to help get this merged?

@Awk34
Copy link
Member

Awk34 commented Sep 4, 2015

@thomporter feel like revisiting this?

kingcody added a commit to kingcody/generator-angular-fullstack that referenced this pull request Sep 8, 2015
@Awk34 Awk34 closed this Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants