-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth) add confirm password to signup and settings #484
Conversation
👍 |
this was passing on my system locally (a full test on the generator, not just testing a generated app.) But then I merged all of the upstream commits in canary, and now it doesn't work locally either. I call fowl! 🐦 BAH! See my comment here: thomporter@a5977c6 |
@thomporter take a look at my build 35 on travis. I believe I encountered the same error you did. Not terribly sure if I understand why, but @DaftMonk's most recent commit to canary cleared it up for me... You should be able to |
confirm password powered by directive: https://github.com/wongatech/angular-confirm-field + adding for attribute to labels and ids to associated elements + fixing invalid password error in settings HTML to ref pwd.old. instead of form.password... (Jade was ok) take note of new dependency in test/fixtures/bower.json (re-run bower install on current clones...)
Awesome. That fixed it online! 😄 But it is still failing locally w/ the same errors... 😦 I removed |
Are you getting the same error as you were on travis? |
yup |
It would seem that your |
Strange. I rebased again, and it's working... Why didn't it work locally the first time, the rebase obviously fixed it for Travis online... 😕 |
Anything I can do to help get this merged? |
@thomporter feel like revisiting this? |
Originally submitted by @thomporter Closes angular-fullstack#484
confirm password powered by directive: https://github.com/wongatech/angular-confirm-field
also adding
for
attribute tolabels
andid
s to associated elementsalso fixing invalid password error in settings HTML to ref
pwd.old.
instead ofform.password.
(Jade was ok)
take note of new dependency in test/fixtures/bower.json (re-run bower install on current clones...)