Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working #3

Open
hairy-tortoise opened this issue Apr 13, 2024 · 4 comments
Open

Not working #3

hairy-tortoise opened this issue Apr 13, 2024 · 4 comments

Comments

@hairy-tortoise
Copy link

When I start a codespace, launch the app and go to the exposed port I get the Flutter loading, but it never finishes. I don't get any errors in the console.

@DanTup
Copy link
Owner

DanTup commented Apr 18, 2024

Yeah, this doesn't seem to work for me anymore. When I click the Dart Debug Extension button I start getting this notification appearing:

Screenshot 2024-04-18 104908

And it just keeps appearing every few seconds, even after I've closed the app window.

I have all ports set to public:

Screenshot 2024-04-18 104914

@elliette do you know what this error is? It's not very clear from the notification I see, and I can't find any more details in any of the consoles for the app or by trying to inspect the extension (there used to be a way to view the "background page" I think, but now I only see a service worker link, and the console there is clear).

(this isn't a priority, but it'd be good to understand what's broken.. it's very possible it's something on codespaces, but the error isn't helpful)

@elliette
Copy link

Ah yes, this was added to fix a potential security vulnerability in the extension (details here: dart-lang/webdev#2287)

@DanTup
Copy link
Owner

DanTup commented Apr 18, 2024

@elliette oh, I see - so do all domains need whitelisting now? Is it possible for the user to add their own (or could we prompt to ask them, rather than just blocking)? (again, not a priority - but would be a shame to lose the ability to use this on services like Codespaces).

@DanTup
Copy link
Owner

DanTup commented Apr 18, 2024

There's an open issue at dart-lang/webdev#2375 tracking support for custom domains that aren't localhost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants