Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update newtype_derive docs to use macro_attr! #29

Open
Rufflewind opened this issue Apr 3, 2017 · 2 comments
Open

Update newtype_derive docs to use macro_attr! #29

Rufflewind opened this issue Apr 3, 2017 · 2 comments

Comments

@Rufflewind
Copy link

I was a bit confused why the crate used a deprecated dependency by the same author! Had to look in the tests to see what the new syntax is like.

@alberdingk-thijm
Copy link

I'd second this for enum_derive. The crate docs for enum_derive have:

custom_derive! {
    #[derive(Debug, PartialEq, Eq,
        IterVariants(CandyVariants), IterVariantNames(CandyVariantNames))]
    pub enum Candy { Musk, FruitRock, BoPeeps, LemonSherbert }
}

whereas this works now as

macro_attr! {
    #[derive(Debug, PartialEq, Eq,
        IterVariants!(CandyVariants), IterVariantNames!(CandyVariantNames))]
    pub enum Candy { Musk, FruitRock, BoPeeps, LemonSherbert }
}

@bluss
Copy link

bluss commented Nov 19, 2017

I think newtype_derive just needs to be published, it looks up to date in git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants