fix: do not fail on closure of already closed Nexus repositories #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 0.00% // Head: 0.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #477 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 11 11
Lines 380 387 +7
Branches 31 32 +1
======================================
- Misses 380 387 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I made a stylistic check. Verify if it keeps working |
I made a minor fix, and now should work |
DanySK
approved these changes
Feb 5, 2023
DanySK
changed the title
DanySK
pushed a commit
that referenced
this pull request
Feb 5, 2023
## [3.2.1](3.2.0...3.2.1) (2023-02-05) ### Bug Fixes * prevent the closing of a staging repository already closed ([#477](#477)) ([8c1311c](8c1311c)) ### Build and continuous integration * change regex to be bash-compliant ([#474](#474)) ([5454a6f](5454a6f)) * fail more clearly ([1e4b851](1e4b851)) * fix pure bash regex matchers ([d1fe58f](d1fe58f)) * improve failure reporting ([1c4822d](1c4822d)) * never release unless all tests pass ([c47a755](c47a755))
|
🎉 This PR is included in version 3.2.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the plugin in a "multi-stage" deployment, on the final job (using semantic-release) the
releaseStagingRepositoryOnMavenCentraltask is called. This task depends on thecloseStagingrepositoryOnMavenCentral, but since the staging repo is closed on the previous CI job (the job that tries to upload and close the staging repo), the staging repo will be closed twice producing the following errors:This PR introduces a check in the
closeStagingrepositoryOnMavenCentralthat if the repository is already closed, skip the closing action, raising a warning saying that the closing task is skippedLet me know how does it sound :)